ESlint + fixes

[akx]

This PR:

• Configures ESLint (and Prettier, though it's not in use) for the repository.
  • The base rules are the Airbnb rules, but with plenty of rules disabled for the time being to make things a little easier for now.
  • The static/ directory is not being linted right now, even if the frontend files (spx_*) in there probably would benefit from it.
• Fixes many ESlint no-undef problems, mostly by way of
  • adding global. to where e.g. io or config is accessed
  • adding const/let/var where it was missing (which may also fix some wonky behavior from variables leaking)
• Fixes no-unused-vars errors, some of which are fixed by getting rid of evals in favor of safer methods
• Fixes most other errors encountered
• Adds a GitHub Actions workflow that runs ESLint.

It should be noted that the workflow does currently fail because there are some uses of eval left I couldn't make heads or tails of, and some other things I didn't quite bother to change right now.

[bilbo-the-hobbit]

hello,

did you follow the release note if you upgraded from another version ?

https://documentation.fusiondirectory.org/en/documentation_admin

Cheers

[vgvassilev]

Hi, I did not upgrade. This is a fresh install.

[bilbo-the-hobbit]

hello,

strange, as the demo.fusiondirectory.org is redone each don from scratch and doesn't exhibit the issue, i just retested it right now.

will talk to colleague to see what could be happening, as i already said in the other bug, test also this one with the fixes version that as better php7 support

Cheers

[vgvassilev]

Thanks, I purged the configs and redid it from scratch and I don't see this issue anymore. I think the issue still needs to be understood, though.

[bilbo-the-hobbit]

yes strange issue we will look into it

Cheers