Dawn icon indicating copy to clipboard operation
Dawn copied to clipboard

Videos in fullscreen media viewer are not fullscreen

Open Donkey-Doug opened this issue 4 years ago • 9 comments

Videos, photos and gifs are not shown fullscreen. As far as I am aware, it is not possible to do so.


We can toggle controls for fullscreen videos but the video itself doesn’t resize and the progress bar stays visible. Instead progress control should hide and video should resize to take all available space.

Donkey-Doug avatar Jun 16 '20 12:06 Donkey-Doug

Viewer that opens on click on media is not enough fullscreen?

AbsurdlySuspicious avatar Jun 16 '20 14:06 AbsurdlySuspicious

Here are some examples of what it looks like on my phone.

Photo in landscape mode. Screenshot_2020-06-16-16-16-02-124_me thanel dank

Same photo in portrait mode. Notice the view is zoomed and I am required to scroll down to see the rest of the image. Screenshot_2020-06-16-16-16-06-087_me thanel dank

Video in landscape. Notice how cluttered the interface is and how inefficient the space is used. The bar to seek and press play/pause should cover the video and be hidden after a second of inactivity, just like the mobile site of reddit or youtube. Screenshot_2020-06-16-16-16-22-675_me thanel dank

Same video in portrait: Screenshot_2020-06-16-16-16-18-644_me thanel dank

Donkey-Doug avatar Jun 16 '20 14:06 Donkey-Doug

They're fullscreen. And photos are sizeable in this mode, of course. Bottom controls can be hidden if you tap again on center of opened media. Missing ability to hide video controls is the only issue I can think of

AbsurdlySuspicious avatar Jun 16 '20 14:06 AbsurdlySuspicious

I am sorry, but they are not fullscreen. This is what fullscreen looks like on my phone (which has a non 16:9 aspect ratio):

Without controls: Screenshot_2020-06-16-16-26-19-539_org schabi newpipe

With controls: Screenshot_2020-06-16-16-27-49-141_org schabi newpipe

Donkey-Doug avatar Jun 16 '20 14:06 Donkey-Doug

And photos are sizeable in this mode, of course.

Nope, can only zoom in. There is no way to show a photo fullscreen in landscape mode, because I cannot zoom out.

Donkey-Doug avatar Jun 16 '20 14:06 Donkey-Doug

Missing ability to hide video controls is the only issue I can think of.

As well as the download, share, open in browser and HD buttons. All of this should be placed over the video content and hidden after a second of inactivity.

Donkey-Doug avatar Jun 16 '20 14:06 Donkey-Doug

Nope, can only zoom in. There is no way to show a photo fullscreen in landscape mode, because I cannot zoom out.

As well as the download, share, open in browser and HD buttons. All of this should be placed over the video content and hidden after a second of inactivity.

These are two separate issues. Please, report them properly with describing titles, so it'd be easier to pick these issues from list for someone who want to work on this

AbsurdlySuspicious avatar Jun 16 '20 14:06 AbsurdlySuspicious

I can see that indeed we can toggle controls for videos but the video itself doesn’t resize and the progress bar is visible. That should be fixed. Lets use this issue to handle this situation.

The problem with image zoom is indeed worthy of its own issue.

Tunous avatar Jun 16 '20 15:06 Tunous

Moved the other one to https://github.com/Tunous/Dawn/issues/260

Tunous avatar Jun 16 '20 15:06 Tunous