TumblThree icon indicating copy to clipboard operation
TumblThree copied to clipboard

[WIP] Don't save incomplete downloaded files

Open yfdyh000 opened this issue 3 years ago • 2 comments

Description

This seems to ensure that no 0-byte files are present. However, clicking stop button still cause some JPEG files to be incomplete while downloading.

CheckDirectoryForFiles option is not visible since 2017, I don't know why.

For coding discussions, any suitable place? Issues, GitHub discussion (not opened, I suggest turning it on and provide some topic), or something else?

Issue Resolution

#257.

Proposed Changes

New or Changed Features

Does this PR provide new or changed features or enhancements? If so, what is included in this PR?

yfdyh000 avatar Jul 04 '22 22:07 yfdyh000

else you can also open an issue, link it if necessary.

Sometimes they are questions or proposals for code changes, refactoring or function change, and I don't really want to pollute real bug reports/feature requests, and it's intrusive for ordinary issues watcher. However, PRs are indeed a good place for a line-by-line review of code.

yfdyh000 avatar Jul 05 '22 20:07 yfdyh000

Maybe we should set up the Discussions thing (to give the users a new forum). As usual, at the end it's not a problem of setting it up, rather the amount of people who will use it...

thomas694 avatar Jul 05 '22 21:07 thomas694