TulipaEnergyModel.jl icon indicating copy to clipboard operation
TulipaEnergyModel.jl copied to clipboard

WIP - DataFrames refactoring

Open abelsiqueira opened this issue 10 months ago • 2 comments

Describe the changes made in this pull request

List of related issues or pull requests

Closes #ISSUE_NUMBER

Collaboration confirmation

As a contributor I confirm

  • [ ] I read and followed the instructions in README.dev.md
  • [ ] The documentation is up to date with the changes introduced in this Pull Request (or NA)
  • [ ] Tests are passing
  • [ ] Lint is passing

abelsiqueira avatar Apr 25 '24 14:04 abelsiqueira

Benchmark Results

179f064058c17c... 1ac6ef440bc684... 179f064058c17c.../1ac6ef440bc684...
energy_problem/create_model 0.108 ± 0.0045 h 0.109 ± 0.0061 h 0.989
energy_problem/input_and_constructor 15.7 ± 1 s 25.7 ± 0.036 s 0.61
time_to_load 2.65 ± 0.011 s 2.68 ± 0.029 s 0.988
179f064058c17c... 1ac6ef440bc684... 179f064058c17c.../1ac6ef440bc684...
energy_problem/create_model 0.738 G allocs: 31 GB 0.738 G allocs: 30.7 GB 1.01
energy_problem/input_and_constructor 16.3 M allocs: 0.829 GB 16.5 M allocs: 2.08 GB 0.399
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

github-actions[bot] avatar Apr 25 '24 14:04 github-actions[bot]

Codecov Report

Attention: Patch coverage is 92.20779% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 99.05%. Comparing base (179f064) to head (1ac6ef4).

Files Patch % Lines
src/time-resolution.jl 86.66% 6 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #612      +/-   ##
===========================================
- Coverage   100.00%   99.05%   -0.95%     
===========================================
  Files           15       15              
  Lines          639      633       -6     
===========================================
- Hits           639      627      -12     
- Misses           0        6       +6     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 25 '24 14:04 codecov[bot]

@abelsiqueira I think we can close this PR. Do you agree?

datejada avatar Oct 15 '24 09:10 datejada