Moonrise icon indicating copy to clipboard operation
Moonrise copied to clipboard

Fabric: Incompatible with Carpet Mod

Open tesseract-two opened this issue 1 year ago • 7 comments

Moonrise crashes with Carpet Mod.

Environment:

Minecraft 1.21
Fabric Loader 0.16.5
Moonrise 0.1.0-beta.2+44f8058
Carpet 1.4.147+v240613
No Telemetry 1.8.0

Carpet's Explosion_scarpetEventMixin appears to conflict with Moonrise's collisions.ExplosionMixin. Setting "required": false in Carpet's carpet.mixins.json allow the game to launch and run fine, and explosions appear to work normally.

tesseract-two avatar Sep 15 '24 19:09 tesseract-two

There's also a three-way incompatibility between Carpet, Moonrise, and Lithium. It's probably related to https://github.com/gnembon/fabric-carpet/pull/1937.

Tested with:

Minecraft 1.21
Fabric Loader 0.16.5
Moonrise 0.1.0-beta.2+44f8058
Lithium 0.13.0
Carpet 1.4.147+v240623 (compiled artifact linked in above PR)
No Telemetry 1.8.0

tesseract-two avatar Sep 15 '24 19:09 tesseract-two

Additionally Architectury API has a similar issue with architectury.mixins.json:MixinExplosion conflicting with collisions.ExplosionMixin

Astropulse avatar Sep 15 '24 22:09 Astropulse

Is this reproducible in 1.21.3?

jpenilla avatar Nov 15 '24 17:11 jpenilla

Yes it also crashes in 1.21.3 crash-2024-11-23_22.56.01-client.txt

Assaro avatar Nov 23 '24 21:11 Assaro

Can you try with disabling optimizedTNT in the carpet config? https://github.com/gnembon/fabric-carpet/blob/27ccd69c86c25357a2385c47db731b43ec5338b6/src/main/java/carpet/CarpetSettings.java#L231

jpenilla avatar Nov 23 '24 22:11 jpenilla

Can you try with disabling optimizedTNT in the carpet config? https://github.com/gnembon/fabric-carpet/blob/27ccd69c86c25357a2385c47db731b43ec5338b6/src/main/java/carpet/CarpetSettings.java#L231

Does this need a recompiled jar?

Assaro avatar Nov 23 '24 23:11 Assaro

Can you try with disabling optimizedTNT in the carpet config? https://github.com/gnembon/fabric-carpet/blob/27ccd69c86c25357a2385c47db731b43ec5338b6/src/main/java/carpet/CarpetSettings.java#L231

Yes even disabling the optionin carpet the mixin is still failing to apply.

hitech95 avatar May 20 '25 12:05 hitech95