Moonrise icon indicating copy to clipboard operation
Moonrise copied to clipboard

Additional incompatibility mods

Open KITE2459 opened this issue 1 year ago • 9 comments

the mod loader used is fabric

[ScalableLux] https://modrinth.com/mod/scalablelux it doesn't work because it's a starlight fork of island that made c2me. it says incompatibility from the server boot.

[no-portals] https://modrinth.com/mod/no-portals

[servercore] https://modrinth.com/mod/servercore

these mods are not on the incompatible list

thanks for developing another optimization mod

KITE2459 avatar Aug 25 '24 10:08 KITE2459

the mod loader used is fabric

[ScalableLux] https://modrinth.com/mod/scalablelux it doesn't work because it's a starlight fork of island that made c2me. it says incompatibility from the server boot.

[no-portals] https://modrinth.com/mod/no-portals

[servercore] https://modrinth.com/mod/servercore

these mods are not on the incompatible list

thanks for developing another optimization mod

I cannot speak for No-Portals & ServerCore, as they appear to provide various changes that are unrelated to Moonrise; however, ScalableLux probably will never be compatible, as Moonrise contains Starlight's patches, which effectively makes using ScalableLux pointless if you're planning on using Moonrise on your server.

R00tB33rMan avatar Aug 25 '24 19:08 R00tB33rMan

Any plans to make the Starlight patches optional via config to support ScalableLux @R00tB33rMan? Since it has further optimisations.

sternschnaube avatar Aug 25 '24 23:08 sternschnaube

ScalableLux is just an outdated version of Starlight besides their one extra patch, and generally speaking lighting chunks isn't a bottleneck or something that would need that kind of parallelization

kennytv avatar Aug 26 '24 11:08 kennytv

Apparently servercore is compatible with moonrise, since 4 days ago in neo and fabric. (https://github.com/user-attachments/assets/1b205d0a-99c3-4c51-a0c1-111adf9e7777)

ImYosu avatar Aug 31 '24 03:08 ImYosu

Chunky don't generate chunk and chunk-pregenerator crash when running a benchmark or any task

coco875 avatar Sep 04 '24 12:09 coco875

forgematica (neoforge port of litematica) also crash like litematica on fabric

coco875 avatar Sep 04 '24 13:09 coco875

with connector, debugify (with some tweak), vmp crash like on fabric

coco875 avatar Sep 04 '24 13:09 coco875

Open Parties and Claims by Xaero and Vanish by DrexHD also seem to crash the server on fabric and it seems there are some Mixin Shenanegans with ModernFix going on

derjungeinhd avatar Sep 06 '24 03:09 derjungeinhd

LOG on mclogs edit: fun fact, my prism borked uploading to mclogs so no logs for now, apologies

most likely this mixin:

mixin.random.world (true) - Replaces all references of Random in World with my implementation

edit2: actually, there are even more incompats with potatooptimzie

org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: @At("INVOKE") on net/minecraft/class_259::redirectListPair1 with priority 1000 cannot inject into net/minecraft/class_259::method_1082(Lnet/minecraft/class_265;Lnet/minecraft/class_265;Lnet/minecraft/class_247;)Lnet/minecraft/class_265; merged by ca.spottedleaf.moonrise.mixin.collisions.ShapesMixin with priority 1000 [INJECT_PREPARE Applicator Phase -> potatoptimize.mixins.json:logic.shape.VoxelShapesMixin from mod potatoptimize -> Prepare Injections -> redirect$kdc000$potatoptimize$redirectListPair1(ILit/unimi/dsi/fastutil/doubles/DoubleList;Lit/unimi/dsi/fastutil/doubles/DoubleList;ZZ)Lnet/minecraft/class_255; -> Prepare ->  -> { target: method_1082(Lnet/minecraft/class_265;Lnet/minecraft/class_265;Lnet/minecraft/class_247;)Lnet/minecraft/class_265; }]

this one i couldn't understand

  • CreativeCore: https://github.com/CreativeMD/CreativeCore/issues/255

  • Methane

	Caused by: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: @At("INVOKE") on net/minecraft/client/particle/Particle::optimiseParticleCollisions with priority 1000 cannot inject into net/minecraft/client/particle/Particle::move(DDD)V merged by com.modrinth.methane.mixin.ParticleMixin with priority 1200 [INJECT_PREPARE Applicator Phase -> moonrise.mixins.json:collisions.ParticleMixin from mod moonrise -> Prepare Injections -> redirect$ioa000$moonrise$optimiseParticleCollisions(Lnet/minecraft/entity/Entity;Lnet/minecraft/util/math/Vec3d;Lnet/minecraft/util/math/Box;Lnet/minecraft/world/World;Ljava/util/List;)Lnet/minecraft/util/math/Vec3d; -> Prepare ->  -> { target: move(DDD)V }]

Particle optimization if i understand correctly

  • Carpet

Which is enough for me already, I can't drop so many mods for Moonrise sadly. I really hope to see it with improved compatibility in the future! Great thing (well, sad that there's a need) that we have so many optimization mods nowadays:D

  • Architectury

Cheers

tajemniktv avatar Sep 16 '24 04:09 tajemniktv

Please open individual issues for each conflicting mod, including details such as the mod loader, versions, crash reports, logs, etc. Unfocused issues like this make things very difficult to take action on.

jpenilla avatar Oct 16 '24 17:10 jpenilla