gnome-shell-extension-clipboard-indicator icon indicating copy to clipboard operation
gnome-shell-extension-clipboard-indicator copied to clipboard

Review for version v39 on e.g.o

Open Tudmotu opened this issue 3 years ago • 2 comments

From @justperfection :

  1. Please remove all .po and .pot files: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files

  2. Lang is a deprecated module. Please remove it for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html

If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions

Tudmotu avatar Nov 14 '21 19:11 Tudmotu

For number 1, I recommend to use gnome-extension pack command for creating packages. It has some benefits:

  • You won't have locale or schema files in your source.
  • You don't need to compile schema and .po files manually.

The package gnome-extension command is generating can be uploaded to the ego. You can also install that package file with gnome-extensions install --force file.zip during developing process.

You can use my script as an example.

Also add these to gitignore to avoid uploading temp and zip files to repo:

*~
*.zip

jrahmatzadeh avatar Nov 14 '21 19:11 jrahmatzadeh

Cool, thanks!

Tudmotu avatar Nov 14 '21 21:11 Tudmotu