Ark-docker icon indicating copy to clipboard operation
Ark-docker copied to clipboard

Fixes instrumenting of cron to preserve environment variables.

Open krobertson opened this issue 7 years ago • 8 comments

This changes the startup script to create a crontab with all of the supported environment variables prepended to it to ensure they are available when calling to arkmanager.

This fixes an issue where updating and restarting from cron would fail to restart the server properly.

This change also includes a number of trailing whitespace trims, as well as an update to the README where the Variables section had a typo for the UPDATEONRESTART entry.

Fixes https://github.com/TuRz4m/Ark-docker/issues/13 and https://github.com/FezVrasta/ark-server-tools/issues/678

krobertson avatar Dec 31 '16 21:12 krobertson

what's your start command of the container

changemenemo avatar Jan 01 '17 18:01 changemenemo

I just use the default one. Dockerfile has it call user.sh.

krobertson avatar Jan 01 '17 19:01 krobertson

I repushed the krobertson/ark:test image I posted on Docker Hub. If you were using it before now, you'll want to repull. I realized I hadn't re-pushed it after correcting the UPDATEONRESTART spelling. Having it wrong resulted in the crontab not loading at all because of a syntax error.

Also, worth noting the startup scripts do not have set -e where an error in the setup does not result in the container failing.

krobertson avatar Jan 01 '17 21:01 krobertson

Great work :) I saw your issue on Ark Server Tools this weekend but I wasn't available. If you're sure it works, I can merge it right now, but I don't have time to test it before the end of the week.

TuRz4m avatar Jan 02 '17 07:01 TuRz4m

ow ow finally turzam show himself :p @krobertson Do you have look at your logs? you don't have different PID now?

changemenemo avatar Jan 02 '17 09:01 changemenemo

Was going to say wait for the next update to see, but looks like 253.71 came out and our server updated and restarted just fine.

krobertson avatar Jan 02 '17 21:01 krobertson

and nothingin the logs?

changemenemo avatar Jan 02 '17 23:01 changemenemo

it's our container itself who decide to go fetch the update right?

changemenemo avatar Jan 03 '17 00:01 changemenemo