TuGraph-family
[optimize] Hard-coded Optimize
Description:
Currently, some values in NettyMessage.java are hard-coded, such as the magic number 0xBADC0FFE, which needs to be constantized.
- ClusterConstants.java: Various prefixes and constants can be extracted as configuration
- NettyMessage.java: The magic number 0xBADC0FFE needs to be constantized
- StringLiteralUtil.java: The multiplier array {1000, 100, 10, 1} needs to be constantized.
- LocalClient.java: The JSON template string needs to be extracted.
Hi @kitalkuyo-gita, I am interested in this for my first issue. Could you assign it to me?
Hi @kitalkuyo-gita, I am interested in this for my first issue. Could you assign it to me?
Hi @Mukvin , I'm glad you're interested in this issue. @Leomrlin @qingwen220 , could you please handle the allocation?
Okay, the maintainers might be a bit busy. You can start working on this issue now. Feel free to leave a comment if you'd like to discuss it.
Hi @kitalkuyo-gita , this pr was created https://github.com/apache/geaflow/pull/674. Anyone could help me to review it ?
Hi @kitalkuyo-gita , this pr was created #674. Anyone could help me to review it ?
I've left some comments; you can check them out when you have time.
Hi @kitalkuyo-gita , this pr was created #674. Anyone could help me to review it ?
I've left some comments; you can check them out when you have time.
Hi @kitalkuyo-gita , I have fixed your comments, pls review it again when you have time. Thanks a lot.
Hi @Mukvin,@ChaomingZhangCN due to the relatively small number of contributors to Geaflow, we haven't opened a Slack channel yet. If you'd like to discuss more Geaflow-related topics, you can join our DingTalk group.
