Tsym-or-Tysm
Tsym-or-Tysm
After some testing, it looks like the 100 frames is actually a pretty decent rule of thumb for now. The primary issue with people being unable to collect their particles...
They were never in debug, but they should be noted somewhere.
Is there anything in game that checks against this tag? If not then I'd prefer to just not deal with it at all right now...
With the new AttackEvent refactor done, this needs to be rechecked for all characters effectively.
Leaving idea here - there should be an error log message that gets carried over across iterations, incrementing a timer +1 if it's still stuck. At the end we should...
It should be available in both places. I have another idea related to what we should show on the summary screen - just need to flesh it out.
This is gated by #256 and so may not get fixed for a while. Basically the problem is that in game, Fischl is locked into her burst animation for a...
That's literally the procedure that I outlined above, unless you're saying that they have some kind of more sophisticated way to get at it a priori?
@srliao The piece that we're still missing from this are flat damage buffs from Shenhe/Yun Jin/Cinnabar Spindle/Redhorn. I think we'd want to think of a way to track those properly...
I was thinking both are useful actually, but more generally there should be a system for tracking the buff that isn't just using the "OnAttackWillLand" hook I think. Perhaps we...