KubernetesTask icon indicating copy to clipboard operation
KubernetesTask copied to clipboard

Task succeeds even if operation fails

Open oyosefi opened this issue 8 years ago • 3 comments

Executing a command, e.g. helm install, that fails and returns a non 0 return value will not make the task fail. I believe the following code should be added to execCommand in base.ts (don't have permission to send a pull request): let r = binary.execSync(); if (r.code != 0){ throw r.error }

oyosefi avatar Oct 11 '17 22:10 oyosefi

@oyosefi you can just fork the repo and do a PR. You are correct in your thinking and this update would be good to have.

dtzar avatar Oct 13 '17 02:10 dtzar

Hi @dtzar, Hi directly contact to me and he is very busy, I'll do it on this weekend and release it. Thank you for your help, always. :)

TsuyoshiUshio avatar Oct 13 '17 06:10 TsuyoshiUshio

I've done the release. Sorry for being late. https://github.com/TsuyoshiUshio/KubernetesTask/releases/tag/3.0.3

TsuyoshiUshio avatar Dec 03 '17 18:12 TsuyoshiUshio