Bogdan Chadkin

Results 335 comments of Bogdan Chadkin

Show me what I asked in https://github.com/react-bootstrap/dom-helpers/issues/51#issuecomment-531229575

Well, I see node_modules are correct. Not yarn problem, not dom-helpers problem. I guess webpack resolver in docz broken. They resolve dom-helpers only from root though there is nested v5...

I actually saw same a lot of times with CRA, Gatsby and Next.js. They all webpack based and somehow modified webpack resolver.

Yes, that's correct https://github.com/react-bootstrap/dom-helpers/blob/master/src/animationFrame.ts#L40-L45 Here's basic utils https://github.com/react-bootstrap/dom-helpers/blob/master/src/addEventListener.ts https://github.com/react-bootstrap/dom-helpers/blob/master/src/removeEventListener.ts Here's their combination https://github.com/react-bootstrap/dom-helpers/blob/master/src/listen.ts

@elyazinho Remove dom-helpers resolutions if you added them and remove `resolve.modules` modification from your webpack config. If something is still broken rise an issue in your webpack wrapper.

What do you use gatsby, docz, cra?

Hi, currently we handle similar case with toLowerCase. Though it's hardcoded now. https://github.com/istarkov/rifm/blob/master/src/Rifm.js#L81-L96 We will probably add `isEqual` prop so you could provide own check considering `,` and `.`.

We found interesting solution. It will be another transformation prop with saving cursor position.

this works with new `replace` api in 0.9