quiet icon indicating copy to clipboard operation
quiet copied to clipboard

User should be able to set autodownload size threshold

Open holmesworcester opened this issue 3 years ago • 2 comments

In "Images & files" tab in settings, there should be a section called "Downloading files" with the text "Automatically download files smaller than___ MB" where that number is user configurable. This should determine the size threshold for autodownload described in #533

holmesworcester avatar Jun 03 '22 15:06 holmesworcester

Since we're tackling this now as part of onboarding for @mcginty I propose tackling this on desktop first and creating a separate issue for mobile.

holmesworcester avatar Nov 03 '25 22:11 holmesworcester

Updated

We're only tackling this on desktop for now.

Req's:

  1. In Community Settings there should be an item "Autodownload Size Limit"
  2. It should say the size limit in a number to the right, like the disappearing messages setting here: https://www.figma.com/design/0j7Nna9zWmfOSNmRmQK1Uh/Quiet-Design-Library?node-id=5788-2548&t=WqsRDndv1RIJmPvg-4
  3. Tapping on this item should take you to a settings screen with the title "Autodownload Size Limit" and the explanatory text "Only files smaller than the chosen limit will download automatically."
  4. This screen can follow the design of our disappearing messages screen here, where each choice can be selected and the selected choice has a checkmark: https://www.figma.com/design/0j7Nna9zWmfOSNmRmQK1Uh/Quiet-Design-Library?node-id=4897-21513&t=WqsRDndv1RIJmPvg-4
  5. The choices should be 1MB, 5MB, 20MB, 100MB, 200MB and 20MB should be the default
  6. Only files under the selected size should autodownload
  7. This size selection does not have to apply to images (that's definitely intended eventually but it makes the project more complicated because it then intersects with how we display images)

Notes:

  1. Currently on settings screens on desktop the title does not display in the top bar; this is known technical debt requiring a bigger refactor and we can leave it this way.
  2. Design Library: https://www.figma.com/design/0j7Nna9zWmfOSNmRmQK1Uh/Quiet-Design-Library?node-id=5952-24893&t=wDJ2N6r8jtrFcR3p-4

holmesworcester avatar Nov 03 '25 22:11 holmesworcester

@mcginty, from what I see, this is already merged in the alpha. Are you okay with moving it to the Ready for QA column?

kingalg avatar Dec 04 '25 12:12 kingalg

@mcginty @holmesworcester, there are a few things that look different than in the instructions. In my opinion, they look fine, but I want to make sure that those changes were approved.

  1. It should say the size limit in a number to the right, like the disappearing messages setting here: https://www.figma.com/design/0j7Nna9zWmfOSNmRmQK1Uh/Quiet-Design-Library?node-id=5788-2548&t=WqsRDndv1RIJmPvg-4

There is no number visible like "off" next to the disappearing messages, but the design looks consistent with the rest of our Settings items. Image

  1. The choices should be 1MB, 5MB, 20MB, 100MB, 200MB, and 20MB should be the default

The implemented choices are: Never, 1MB, 2MB, 5MB, 10MB, 20MB (default), 50MB, 100MB, 200MB, 500MB, 1GB, Always.

(I'm still testing how well it works; with connection issues, it's a bit slow. I'll keep you updated.)

kingalg avatar Dec 04 '25 12:12 kingalg

We deviated from the designs here for expediency and these are approved. Should have noted it in the issue, my bad. Thanks for catching and checking!

holmesworcester avatar Dec 04 '25 20:12 holmesworcester

We deviated from the designs here for expediency and these are approved. Should have noted it in the issue, my bad. Thanks for catching and checking!

holmesworcester avatar Dec 04 '25 20:12 holmesworcester

Thanks! I agree that it all looks really good, so it was just a matter of confirming whether the differences had been approved.

@holmesworcester, I found one bug (https://github.com/TryQuiet/quiet/issues/3038), and @mcginty already has a PR with a fix for it. Do you want to release another alpha with the fix, or are you fine with having this bug in the next prod release and releasing the fix later? The bug is not breaking the whole app, so it's not huge, but if you want to demo this part of the app in the near future, we can choose to fix it before going to prod.

kingalg avatar Dec 05 '25 11:12 kingalg