quiet
quiet copied to clipboard
TryQuiet
Emoji-only messages should have larger font size
Most messaging apps increase the font size of emoji-only messages because this makes the emoji more visible and fun. We should too!
Use Slack, Signal, or WhatsApp as a reference for emoji size.
Bonus: in-line emojis should have a larger font size too. (Slack seems to render them as images at 22px.)
Hi @leblowl and @EmiM 👋 I'm a new contributor getting started with this issue. I have code ready to go, but am running into a weird situation with the pre-commit hooks. When I try to commit, lerna runs and I see my code change from the ' character to the " character and then back to ' again, after which it reports eslint/prettier errors as if it settled on " . I'm assuming this is a config problem on my end, but if you've seen this before, please let me know! Screenshot attached.
I added that pre-commit hook and it seems to have issues with linting on files that aren't configured to be linted. I haven't had a chance to look into it but for now if you run the linter with --fix (you can do this at the root by running npm run lint:all) then you can commit with --no-verify. This is just an issue with lint-staged which is only on the pre-commit.
Thanks! This worked and I've put up a PR. Let me know if I missed anything or if there are needed changes.
I think just that issue with tests that Lucas replied to. Thank you for this! Quiet will be 50% more emotive!
@holmesworcester, it's not in the issue specifications, but was this only for desktops? It's implemented correctly on desktop, but on iOS and Android, the size didn't change.
Let's create a new issue for mobile that refers to this issue. Can you do that? For these 'good first issue' issues we are okay with people doing desktop only.
Sure, this is an issue for mobile: Use Slack, Signal, or WhatsApp as a reference for emoji size. And I'm closing this one.
Version: 2.2.0-alpha.0