node-sqlite3 icon indicating copy to clipboard operation
node-sqlite3 copied to clipboard

move to promises (and async/await)

Open ORESoftware opened this issue 7 years ago • 2 comments

Hey! :)

I like the API you use as is - it reminds me of what Selenium-Webdriver did for Node.js as well. (Read below).

But I am wondering if this library has plans to move to async/await instead of the homegrown flow control currently used. I like the methodology you used (is there a name for it?) but it's hard to mix other async flow control with your library.

For the record - selenium-webdriver did something similar to this library whereby every (async) call was put on a queue - they moved to promises (which will work with async await of course).

You can read about that here: https://github.com/SeleniumHQ/selenium/wiki/WebDriverJs

and here: https://seleniumhq.github.io/selenium/docs/api/javascript/module/selenium-webdriver/lib/promise.html

Might be a good excuse to update the lib, or maybe you'd recommend forking it and applying the changes if Mapbox doesn't see a need?

ORESoftware avatar Jun 20 '17 03:06 ORESoftware