node-sqlite3 icon indicating copy to clipboard operation
node-sqlite3 copied to clipboard

Add openssl_fips to binding.gyp

Open msotnikov opened this issue 2 years ago • 3 comments

Fix this issue https://github.com/nodejs/node-gyp/issues/2673#issuecomment-1165324060

msotnikov avatar Feb 20 '23 09:02 msotnikov

Seconding this, would be nice to have latest install without downgrading node-gyp.

timmypidashev avatar Jan 13 '24 09:01 timmypidashev

Can someone explain why this is needed, or at least provide a repro to show the breaking case?

daniellockyer avatar Jan 18 '24 08:01 daniellockyer

Can someone explain why this is needed, or at least provide a repro to show the breaking case?

Its really an obligatory fix due to the latest node versions not playing nicely with node-gyp. I personally am now using an older version(node-sqlite3 5.1.6) to bypass this issue, as it seems the issue is some breaking feature in 5.1.7. I'm fairly new to node-gyp, so I can't really give an explanation as to why this fixes it. The really fun part is, downgrading node to lts variants or even older releases does not remove this error...

timmypidashev avatar Jan 20 '24 04:01 timmypidashev