node-sqlite3 Database.backup() typings?

Database.backup() typings?

Open benallfree opened this issue 3 years ago • 6 comments

Hi, I noticed there are no TS typings for Database.backup and the Backup class.

Would you like a PR for that?

https://github.com/TryGhost/node-sqlite3/blob/master/src/backup.h#L17

Add typings and wiki docs for https://github.com/TryGhost/node-sqlite3/blob/master/src/backup.h#L17

Nov 10 '22 17:11 benallfree

A PR for this would be great 🙂

Nov 11 '22 04:11 daniellockyer

one year later, no changes on this this yet.

Oct 31 '23 16:10 ethyaan

@ethyaan Thanks for reminding me, I just made a PR for this.

Oct 31 '23 16:10 benallfree

@daniellockyer Check it out please :)

Oct 31 '23 16:10 benallfree

@benallfree Thank you, and btw any hands required? just let me know.

Oct 31 '23 21:10 ethyaan

Why is this still open?

Jul 02 '24 11:07 viniciusteixeiradias