Specified why we need to test on staging

[allouis]

In an engineering meeting on 4th December 2024 we discussed that performance on our local machines is not comparable to a production environment, the outcome of this meeting was an agreement that we would test migrations on staging (or production-like environment) in order to understand the performance qualities.

[coderabbitai[bot]]

Walkthrough

The migration review GitHub workflow file was updated to revise the wording of a checklist item. The item previously stated "Tested on the staging database servers" and was changed to "Tested performance on the staging database servers," clarifying that performance testing is required and that performance on local machines is not comparable to a production environment. No other modifications were made to the checklist or the workflow's logic. No changes were made to any exported or public entities.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

[!NOTE]

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b2265f4c3de533801a6290781d134eed6566ca65 and 369bc6a5ac701c62c7944bfebb88da229b98a753.

📒 Files selected for processing (1)

• .github/workflows/migration-review.yml (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• .github/workflows/migration-review.yml

✨ Finishing Touches

🧪 Generate unit tests

• [ ] Create PR with unit tests
• [ ] Post copyable unit tests in a comment
• [ ] Commit unit tests in branch allouis-patch-1

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov[bot]]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 71.54%. Comparing base (cd367be) to head (369bc6a). :warning: Report is 19 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #23325      +/-   ##
==========================================
+ Coverage   71.52%   71.54%   +0.01%     
==========================================
  Files        1530     1530              
  Lines      114866   114866              
  Branches    13836    13940     +104     
==========================================
+ Hits        82163    82182      +19     
+ Misses      31689    31672      -17     
+ Partials     1014     1012       -2     

Flag	Coverage Δ
admin-tests	48.68% <ø> (+0.11%)	:arrow_up:
e2e-tests	71.54% <ø> (+0.01%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ErisDS]

Cleaning up older PRs 💅

(we should reopen and merge this tomorrow or something)