Ghost icon indicating copy to clipboard operation
Ghost copied to clipboard

Internal linking doesn't work in Firefox

Open dkalpakchi opened this issue 1 year ago • 5 comments

Issue Summary

When I try add internal links in Ghost admin in Firefox using @ shortcut nothing happens. The expected result is to get Find a post, tag or author menu

Steps to Reproduce

  1. Start a new post in Ghost admin in Firefox
  2. Write @ and see no reaction to this

Ghost Version

5.101.4

Node.js Version

18.15.0

How did you install Ghost?

Via Ghost CLI

Database type

SQLite3

Browser & OS version

Firefox 132.0.2, Ubuntu 24.04.1

Relevant log / error output

No response

Code of Conduct

  • [X] I agree to be friendly and polite to people in this repository

dkalpakchi avatar Nov 25 '24 19:11 dkalpakchi

Hello @dkalpakchi, thanks for the report! I can reproduce the issue with the provided steps, there seems to be a regression on Firefox. I have pinged the team who worked on Internal Linking to investigate further

sagzy avatar Nov 26 '24 04:11 sagzy

Little update here - this isn't a regression, but rather a long-standing bug with Firefox. Unfortunately the way Firefox fires events is quite different to other browsers.

There's some spike code here which attempted to fix the issue, but it ended up being non-trivial.

A PR fixing this issue would be very welcome 🙏

ErisDS avatar Dec 11 '24 17:12 ErisDS

Hi and thanks for the update! As a Firefox user, I would very much like to give it a shot and try fixing the bug. I'm new to the Ghost codebase though, so I'm just learning to find my way around :slightly_smiling_face:

I assume you mean a PR to this repo: https://github.com/TryGhost/Koenig?

dkalpakchi avatar Dec 11 '24 17:12 dkalpakchi

Just wanted to check back in on this as it is still an issue.

DoNotResuscitate avatar Mar 10 '25 09:03 DoNotResuscitate

I added some further details in a separate issue (closed, since it's a duplicate of this): https://github.com/TryGhost/Ghost/issues/22421

betschki avatar Mar 10 '25 09:03 betschki

Our bot has automatically marked this issue as stale because there has not been any activity here in some time.

The issue will be closed soon if there are no further updates, however we ask that you do not post comments to keep the issue open if you are not actively working on a PR.

We keep the issue list minimal so we can keep focus on the most pressing issues. Closed issues can always be reopened if a new contributor is found. Thank you for understanding 🙂

github-actions[bot] avatar Aug 08 '25 06:08 github-actions[bot]

Hi 👋🏻 I've proposed a solution in https://github.com/TryGhost/Koenig/pull/1492 . It's stale and probably needs a rebase now, which I'm happy to do, it just wasn't clear if there was any interest in merging.

francesmcmullin avatar Aug 08 '25 16:08 francesmcmullin