Inconsistent Portal UX: "Display name in signup form"

[alexgmathews]

Issue Summary

If you turn off "Display name in signup form" in [Portal] > [Signup options], the "Name" field still shows if a member logs in, opens the [Your account] panel, and clicks [Edit]

Steps to Reproduce

n/a

Ghost Version

5.96.1

Node.js Version

18.20.4

How did you install Ghost?

Docker ghost:5-alpine

Database type

MySQL 8

Browser & OS version

No response

Relevant log / error output

No response

Code of Conduct

• [X] I agree to be friendly and polite to people in this repository

[ryzen-xp]

/assign

[KrishnaShuk]

Do you want to remove [Name] field in [Your Account] panel?

[alexgmathews]

@ryzen-xp & @KrishnaShuk - I added more detail to my issue summary.

[cathysarisky]

It seems to me like the name field should be optional if the name is not required in the portal settings.

I'd be reluctant to hide it entirely, unless there's a plan for the case where the member has a name in the system but cannot edit it because portal isn't showing the field...

[elinakocarslan]

Is this issue fixed?

[cathysarisky]

@elinokocarslan , typically when an issue is fixed, it gets closed. Occasionally it happens that an issue gets fixed but not closed because the fix doesn't get linked to the issue -- so I just checked the latest version of Ghost. I turned off names in the portal settings, then opened the 'my account' page in portal. I saw my name (previously entered). I was able to delete my name and save, without needing to enter a name, so the behavior is currently not quite as you described. (Perhaps someone made some improvements.)

So... it's better in that you don't HAVE to enter your name if names are off. But the field still shows. I'll return to my previous comment, that if the name field is filled in, it probably should still show (because otherwise the user would have no way of changing a typo). What do you think about that? Should it only display if it has a value, when names are turned off?

Update: I turned names back on. The current version of Portal is not requiring names to be filled in, period, even if they're turned on.

[elinakocarslan]

Thank you! Yes I was confused because some aspect of the functionality was fixed. I do agree I feel the name field should still show. So the only thing to fix now, is to make sure that when name requirement is turned on, the name field should be required, right?

[cathysarisky]

Ahha. Looks like it was updated here: https://github.com/TryGhost/Ghost/commit/4ec0bdde3c43cfb4c19b997f39058d2b6f3f03ef @minimaluminium , do you consider this issue closed, or would it make sense to also hide the (empty?) name field when names are off?

Based on conversations with clients, some users who have names turned on really want names to be required, and that PR undid that expectation...

[juliuspopp]

I have the opposite issue: When the setting is on

I expect the name field to also show for embeddable signup forms:

But there the name field is not visible.

I agree that there should be two settings:

• Show Name Field
• Make Name required

And both should apply to the embeddable form as well, otherwise they become useless for some users.

[github-actions[bot]]

Our bot has automatically marked this issue as stale because there has not been any activity here in some time.

The issue will be closed soon if there are no further updates, however we ask that you do not post comments to keep the issue open if you are not actively working on a PR.

We keep the issue list minimal so we can keep focus on the most pressing issues. Closed issues can always be reopened if a new contributor is found. Thank you for understanding 🙂

[juliuspopp]

This is not a "most pressing issues" if I cannot fix it myself? That's a weird policy.

Not pressing should be gauged by a human.

Is ist "not pressing" for a publication if there's a bug in the sign-up flow?

[github-actions[bot]]

Our bot has automatically marked this issue as stale because there has not been any activity here in some time.

The issue will be closed soon if there are no further updates, however we ask that you do not post comments to keep the issue open if you are not actively working on a PR.

We keep the issue list minimal so we can keep focus on the most pressing issues. Closed issues can always be reopened if a new contributor is found. Thank you for understanding 🙂