Ghost icon indicating copy to clipboard operation
Ghost copied to clipboard

Review of all translation fixed, missed some things here.

Open fochoa8 opened this issue 1 year ago • 5 comments

Got some code for us? Awesome 🎊!

Please include a description of your change & check your PR against this list, thanks!

  • [x] There's a clear use-case for this code change, explained below
  • [x] Commit message has a short title & references relevant issues
  • [ ] The build will pass (run yarn test:all and yarn lint)

We appreciate your contribution!

fochoa8 avatar Oct 07 '24 12:10 fochoa8

Please review this pull request. Sorry if I am being impatient. But I want the real translation up.

Duplicate submissions slow the process down, because it means that changes are spread across multiple PRs instead of all on the same one. I've left you two comments already on this PR, and it's back in your court to respond to them.

The next Portal release is likely to be no sooner than Friday.

cathysarisky avatar Oct 07 '24 22:10 cathysarisky

Sorry, I just realized I didn't click the button to make those two comments/questions 'live', which explains why you haven't responded to them, I suppose!

cathysarisky avatar Oct 08 '24 03:10 cathysarisky

@fochoa8 Would you mind getting back to us here https://github.com/TryGhost/Ghost/pull/21246#discussion_r1807153846 so we can decide whether or not to merge this

allouis avatar Oct 23 '24 09:10 allouis