Ghost icon indicating copy to clipboard operation
Ghost copied to clipboard

Comments don't play well with theme toggles

Open cathysarisky opened this issue 1 year ago • 4 comments

Issue Summary

(This report references comments-ui version 0.17)

The mode="auto" styling works great -- it's awesome that themes that are running in dark mode automagically get dark mode for comments too. HOWEVER (yeah, there's always a however), themes with a toggle to let the user choose between dark/light cause the auto mode to break, as the comments iframe does not adjust colors when the theme does.

Theme creators could work around this by providing a background behind the comments that doesn't change when the slider is toggled after the page load, but that's going to be a pretty ugly hack and means that the comments are going to look weirdly wrong after the toggle button is flipped on that page.

Is there a way to make comments-ui detect that the color of the container has changed?

Steps to Reproduce

Quick way to fake switching modes: Add (or remove) "class='dark-mode'" to the html tag in casper.

Ghost Version

5.92

Node.js Version

18

How did you install Ghost?

WSL2/using Ghost-cli

Database type

MySQL 8

Browser & OS version

chrome/ Windows 10

Relevant log / error output

No response

Code of Conduct

  • [X] I agree to be friendly and polite to people in this repository

cathysarisky avatar Sep 24 '24 21:09 cathysarisky

Assign me this I will work on it

Priyanshu-su30 avatar Oct 02 '24 08:10 Priyanshu-su30

I would like to resolve this.

omchaudhary007 avatar Oct 13 '24 07:10 omchaudhary007

/assign

omchaudhary007 avatar Oct 13 '24 07:10 omchaudhary007

I'd like to work on this.

reallywasi avatar Oct 13 '24 18:10 reallywasi