Ghost icon indicating copy to clipboard operation
Ghost copied to clipboard

editor shortcuts collision on firefox

Open johnHackworth opened this issue 1 year ago • 3 comments

Issue Summary

The shortcut to convert the selected text to a quote (ctrl+Q) doesn't work on firefox (130.0) because it's already used by the browser (to close all the windows) and can't be overtaken by a site.

Steps to Reproduce

  1. Edit a post with Firefox 130.0
  2. Write a text & select it
  3. Press Ctrl+Q

Ghost Version

5.94.1

Node.js Version

18.20.0

How did you install Ghost?

using ghost-cli

Database type

MySQL 5.7

Browser & OS version

Firefox 130.0 on Ubuntu 22.04.4

Relevant log / error output

imagen

Code of Conduct

  • [X] I agree to be friendly and polite to people in this repository

johnHackworth avatar Sep 17 '24 08:09 johnHackworth

Hey johnHackworth, thanks for raising the issue šŸ™

sagzy avatar Sep 17 '24 10:09 sagzy

I suggest redefining the shortcut to Ctrl+Shift+Q to avoid conflicts with the existing Firefox shortcut (Ctrl+Q). I’d like to work on this issue and implement the change.

Thank you!

suryatejess avatar Sep 18 '24 13:09 suryatejess

Ctrl+Shift+Q seems like a logical alternative. There are other shortcuts that use the Control+Shift prefix.

markstos avatar Sep 21 '24 18:09 markstos

Our bot has automatically marked this issue as stale because there has not been any activity here in some time.

The issue will be closed soon if there are no further updates, however we ask that you do not post comments to keep the issue open if you are not actively working on a PR.

We keep the issue list minimal so we can keep focus on the most pressing issues. Closed issues can always be reopened if a new contributor is found. Thank you for understanding šŸ™‚

github-actions[bot] avatar Jan 12 '25 19:01 github-actions[bot]