Recommendations do not work for Instagram profiles

[cathysarisky]

Issue Summary

The recommendations-related /check endpoint does not correctly parse the response from Instagram:

1. Prepopulated fields are generic, not from the profile
2. The recommendation feature_image is base64 encoded and causes the recommendation to be rejected upon attempting to save.

Steps to Reproduce

Add a recommendation to an Instagram Profile. Observe prepopulated fields. Attempt to save it.

Details (from this forum post: https://forum.ghost.org/t/valid-url-issue-with-recommendations/45281/8 )

Prior to saving, what's populating the preview looks like a login page, not the profile page entered, although the URL is the profile page. And the image URL is actually base64-encoded, which is probably what's breaking things on attempting to save.

Ghost Version

Ghost Pro

Node.js Version

Ghost Pro

How did you install Ghost?

Ghost Pro

Database type

MySQL 8

Browser & OS version

Chrome, Windows 10, freshly updated

Relevant log / error output

Here's what the /check endpoint returns:

{
    "recommendations": [
        {
            "id": null,
            "title": "Login • Instagram",
            "description": null,
            "excerpt": "Welcome back to Instagram. Sign in to check out what your friends, family & interests have been capturing & sharing around the world.",
            "featured_image": "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAKAAAADTbI/v/KBhsCbrDBhoAbbAi4wQYbAm6wIeAGG2wIuMGGgBtssCHgBhsCbrDB/wlKajuIhIz6AQAAAABJRU5ErkJggg==",  (Truncated before posting issue)
            "favicon": "https://static.cdninstagram.com/rsrc.php/v3/yG/r/De-Dwpd5CHc.png",
            "url": "https://www.instagram.com/yomikestevens/", 
            "one_click_subscribe": false,
            "created_at": null,
            "updated_at": null
        }
    ]
}
===================================

And here's the 422 response on trying to save the recommendation with the (incorrect) check response above.  

{
    "errors": [
        {
            "message": "Validation error, cannot save recommendation.",
            "context": "recommendations.0.featured_image must be a valid URL",
            "type": "ValidationError",
            "details": null,
            "property": null,
            "help": null,
            "code": null,
            "id": "f6d58dd1-d573-11ee-9d12-7d870f824854",
            "ghostErrorCode": null
        }
    ]
}

Code of Conduct

• [X] I agree to be friendly and polite to people in this repository

[dipaksinha1]

Hi @cathysarisky , Can you assign me this task?

[github-actions[bot]]

Our bot has automatically marked this issue as stale because there has not been any activity here in some time.

The issue will be closed soon if there are no further updates, however we ask that you do not post comments to keep the issue open if you are not actively working on a PR.

We keep the issue list minimal so we can keep focus on the most pressing issues. Closed issues can always be reopened if a new contributor is found. Thank you for understanding 🙂