Ghost icon indicating copy to clipboard operation
Ghost copied to clipboard

Update dependencies to fix installing in arm32

Open LaurentGoderre opened this issue 1 year ago • 1 comments

Installing on arm32 (and perhaps arm64) on Alpine Linux architecture fails due to re2 a dependency of metascraper.

References: https://github.com/microlinkhq/metascraper/pull/681 https://github.com/docker-library/ghost/issues/400

LaurentGoderre avatar Dec 21 '23 14:12 LaurentGoderre

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.65%. Comparing base (a309a29) to head (20c43e8). Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19401   +/-   ##
=======================================
  Coverage   72.65%   72.65%           
=======================================
  Files        1255     1255           
  Lines       73532    73532           
  Branches     9791     9791           
=======================================
  Hits        53425    53425           
  Misses      19353    19353           
  Partials      754      754           
Flag Coverage Δ
admin-tests 39.88% <ø> (ø)
e2e-tests 81.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 14 '24 20:01 codecov[bot]

@sagzy this is causing issues running Ghost on Arm (like on Mac with M1 or M2 chipset)

LaurentGoderre avatar Mar 07 '24 21:03 LaurentGoderre

@LaurentGoderre Thanks for the fix. I've got Fedora Linux installed on an M1 Mac Mini here at home (arm64v8). I'm hoping to move my Ghost hosting there to save money and to make my Ghost hosting solar powered. Without your fix, the Ghost builds are stuck at 5.75.1. I hope this gets merged soon so that Ghost users on this architecture can run a modern and secure version of Ghost.

markstos avatar Mar 27 '24 11:03 markstos

@dvdwinden any chance this could get a review?

LaurentGoderre avatar Apr 09 '24 20:04 LaurentGoderre

Thanks @LaurentGoderre! Apologies for the delay. This should be released on Friday 🙂

daniellockyer avatar Apr 16 '24 07:04 daniellockyer

@daniellockyer the docker image doesn't work anymore. It builds fines but at runtime it throws this error: https://github.com/nrwl/nx/issues/19249

LaurentGoderre avatar Apr 19 '24 19:04 LaurentGoderre