Ghost icon indicating copy to clipboard operation
Ghost copied to clipboard

Issue with rendering text in the Signup card

Open fueko opened this issue 2 years ago • 3 comments

Issue Summary

The Signup card does not receive the style with white text (as is the case with the header card) when the card background is set to dark. As a result, this makes the text illegible and inconsistent with contrast principles.

For example Header card: Zrzut ekranu 2023-12-6 o 10 06 06

Steps to Reproduce

Add a Signup card and set a dark background color.

Ghost Version

5.75.1

Node.js Version

18.12.1

How did you install Ghost?

localhost

Database type

SQLite3

Browser & OS version

All

Relevant log / error output

No response

Code of Conduct

  • [X] I agree to be friendly and polite to people in this repository

fueko avatar Dec 06 '23 09:12 fueko

Hi @daniellockyer can I work on this.

jaswalsaurabh avatar Dec 16 '23 14:12 jaswalsaurabh

I've found that there is an issue with the conversion of lexical to html. This is the root cause which causing the issueconst useTextColor = !nodeData.backgroundColor === 'transparent';. Its in this dependency @tryghost/kg-default-nodes.

jaswalsaurabh avatar Dec 16 '23 15:12 jaswalsaurabh

I've cloned the repo of koenig-editor and found out that this issue is fixed by Steve Larson on Dec 14. But when I check the installed @tryghost/kg-default-nodes module, those changes are not reflected yet in this. But the version are same 1.0.3

jaswalsaurabh avatar Dec 17 '23 06:12 jaswalsaurabh

Our bot has automatically marked this issue as stale because there has not been any activity here in some time.

The issue will be closed soon if there are no further updates, however we ask that you do not post comments to keep the issue open if you are not actively working on a PR.

We keep the issue list minimal so we can keep focus on the most pressing issues. Closed issues can always be reopened if a new contributor is found. Thank you for understanding 🙂

github-actions[bot] avatar Apr 15 '24 07:04 github-actions[bot]