Ghost icon indicating copy to clipboard operation
Ghost copied to clipboard

Removed bluebird dependency

Open Navarjun opened this issue 2 years ago • 4 comments

Issue #14882

  • Bluebird promise was being used for getting cached image sizes using .props method. It has been removed to be replaced by native promise using Promise.all

Navarjun avatar May 28 '22 23:05 Navarjun

Codecov Report

Merging #14940 (5a94add) into main (3231863) will increase coverage by 0.00%. The diff coverage is 39.58%.

@@           Coverage Diff           @@
##             main   #14940   +/-   ##
=======================================
  Coverage   52.60%   52.60%           
=======================================
  Files        1392     1392           
  Lines       89130    89137    +7     
  Branches    10131    10130    -1     
=======================================
+ Hits        46884    46888    +4     
- Misses      42194    42197    +3     
  Partials       52       52           
Impacted Files Coverage Δ
ghost/core/core/frontend/meta/image-dimensions.js 55.07% <38.29%> (+5.89%) :arrow_up:
ghost/core/core/frontend/meta/get-meta.js 100.00% <100.00%> (ø)
ghost/admin/app/components/gh-file-uploader.js 89.47% <0.00%> (-2.26%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar May 30 '22 16:05 codecov[bot]

I re-ran all the tests on my end… everything passes. In the subsequent commits, I have removed BB from another file in the same folder.

Navarjun avatar May 31 '22 00:05 Navarjun

Hey @Navarjun, nice to see you here! Thank you for this PR, really appreciate you taking the time to help out. I've just updated the original issue to be a bit clearer that we need to remove catch predicates first (and why). I'll hold onto this PR and merge it once that work is done.

ErisDS avatar Jun 03 '22 13:06 ErisDS

@ErisDS when to merge? I am reviewing the repo step by step. So many source codes can be decreased. So many source codes can be refactored by modern syntax!

anlexN avatar Jun 06 '22 07:06 anlexN

Hey @Navarjun hope your'e doing well! We finally got rid of all the catch predicates, so I've merged this. Thanks again!

ErisDS avatar Aug 24 '22 14:08 ErisDS