Ghost icon indicating copy to clipboard operation
Ghost copied to clipboard

Remove BB dep from Resources and fix small typo

Open Dave3of5 opened this issue 2 years ago • 3 comments

My first PR for the project. Started off with a small change for #14882. It's only a single file (two actually) change as was mentioned in the Issue.

I also fixed a typo in a function name.

Dave3of5 avatar May 28 '22 12:05 Dave3of5

Codecov Report

Merging #14939 (2e5401e) into main (96f7b8f) will increase coverage by 0.00%. The diff coverage is 8.00%.

@@           Coverage Diff           @@
##             main   #14939   +/-   ##
=======================================
  Coverage   52.56%   52.56%           
=======================================
  Files        1392     1392           
  Lines       89276    89265   -11     
  Branches    10142    10142           
=======================================
- Hits        46926    46922    -4     
+ Misses      42299    42292    -7     
  Partials       51       51           
Impacted Files Coverage Δ
ghost/core/core/server/services/url/UrlService.js 75.37% <0.00%> (ø)
ghost/core/core/server/services/url/Resources.js 42.34% <8.33%> (+0.34%) :arrow_up:
ghost/admin/app/utils/publish-options.js 81.56% <0.00%> (-0.56%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar May 30 '22 16:05 codecov[bot]

Hey @Dave3of5, thank you for this PR, really appreciate you taking the time to help out. I've just updated the original issue to be a bit clearer that we need to remove catch predicates first (and why). I'll hold onto this PR and merge it once that work is done.

ErisDS avatar Jun 03 '22 13:06 ErisDS

@ErisDS Got it, I'll look at creating some PR's for removing the catch predicates then first.

Dave3of5 avatar Jun 05 '22 22:06 Dave3of5

@daniellockyer this looks good to me, and like it will prob improve debuggability of issues with the url service, but can you also cast your eyes over before I merge it? Thanks!

ErisDS avatar Aug 24 '22 14:08 ErisDS