Ghost-CLI icon indicating copy to clipboard operation
Ghost-CLI copied to clipboard

Feat: Add support for named start

Open vikaspotluri123 opened this issue 6 years ago β€’ 7 comments

Adds functionality similar to the stop command - ghost start {name} now works as ghost stop {name} always has

I realized this wasn't a thing as I was testing #765, and given the Stop command already has this functionality, I figured it would be a 5 minute fix, but it turns out both the Start and Stop Command Unit tests aren't super dry, so I ended up going down the rabbit hole of drying up the tests. It might be easier to review commit by commit 😬

I know this coincides w/ the release of 1.9.0; I don't think it will make much of a difference if this gets released before or afterwards.

vikaspotluri123 avatar Jul 28 '18 05:07 vikaspotluri123

Coverage Status

Coverage remained the same at 100.0% when pulling 593d851da04fdbf1511079931ba1d7a695086229 on vikaspotluri123:feat/named-start into 77188efab64f61810854d020ca14ba56246938a0 on TryGhost:master.

coveralls avatar Jul 28 '18 05:07 coveralls

@acburdine everything's been fixed now πŸ˜„

vikaspotluri123 avatar Jul 29 '18 20:07 vikaspotluri123

Rebased! πŸ™ƒ

vikaspotluri123 avatar Sep 05 '18 04:09 vikaspotluri123

Couple things:

  • Do we want to add parity between stop, start, and update? There is a feature request for update --all, and we can add support for start --all as well.
  • Should get-instance be used / run in the System Class?

vikaspotluri123 avatar Oct 10 '20 20:10 vikaspotluri123

Our bot has automatically marked this PR as stale because there has not been any activity here in some time. If we’ve failed to review your PR & you’re still interested in working on it, please let us know. Otherwise this PR will be closed shortly, but can always be reopened later. Thank you for understanding πŸ™‚

github-actions[bot] avatar May 03 '21 15:05 github-actions[bot]

Is there anything outstanding that prevents us from merging this PR? There may be more things we want to do, but if this change is valid and useful, let's get it in? πŸ˜„

ErisDS avatar Aug 30 '22 16:08 ErisDS

Nothing on my side!

vikaspotluri123 avatar Aug 30 '22 16:08 vikaspotluri123