OpenGothic icon indicating copy to clipboard operation
OpenGothic copied to clipboard

Added arm64 as supported architecture for edd-dbg

Open pawcijo opened this issue 1 year ago • 5 comments

Fix for macos build, not sure if this is the right place for PR :)

pawcijo avatar Oct 18 '24 00:10 pawcijo

Hi, @pawcijo !

added arm64 as supported architecture

Can you clarify this statement? Arm64 for mac been supported for a while, with no build issues. Or do you mean crash-logger support?

Try avatar Oct 18 '24 23:10 Try

When i try to build the project on m1 macbook i get "unsupported architecture :(". If frames.cpp is from crash-logger than yes your right :)

pawcijo avatar Oct 21 '24 17:10 pawcijo

How do you build opengothic on mac? edd library is enabled only on windows targets

Try avatar Oct 21 '24 17:10 Try

The same as it goes in Readme : cmake -H. -Bbuild -DCMAKE_BUILD_TYPE:STRING=RelWithDebInfo cmake --build ./build --target Gothic2Notr

pawcijo avatar Oct 21 '24 18:10 pawcijo

Hm, something is not quite right here. Can you please provide build log, cmake version, and more details overall?

In build script there is:

add_subdirectory(lib/edd-dbg)
include_directories(lib/edd-dbg/include)
if(WIN32)
  target_link_libraries(${PROJECT_NAME} edd_dbg)
endif()

Maybe add_subdirectory behaves different across different versions.

Try avatar Oct 21 '24 19:10 Try

Cannot reproduce anymore, it might have been some wild cmake error on macos

pawcijo avatar Oct 24 '24 23:10 pawcijo