trustroots icon indicating copy to clipboard operation
trustroots copied to clipboard

Add information that Trustroots Foundation is dissolved.

Open mariha opened this issue 1 year ago • 3 comments

This change:

Fixes #2585

mariha avatar Aug 12 '22 02:08 mariha

btw not sure if we need to extract the translation strings. According to our i18n docs, they'll get extracted when we merge this to master.

Not sure if that still works though. In any case, manual extraction won't do any harm... :)

mrkvon avatar Aug 12 '22 15:08 mrkvon

I'm opposed to merging this until a valid rationale has been shared in #2585.

chmac avatar Aug 13 '22 21:08 chmac

@mrkvon Given that #2587 had to be done, extract-i18n is not run (successfully).

I created #2589 to fix it.

@chmac I shared my rationale.

mariha avatar Aug 14 '22 02:08 mariha

Mergeable by non-owners. Progress discussion? Merge?

mrkvon avatar Sep 23 '22 17:09 mrkvon

I'm merging it.

There was a suggestion that the wording may not make best impression on potential new members, but others didn't confirm, clarify or object.

As to me, the question is a way to express our, volunteers team members, insecurities.

At this point (1,5 month after making a PR) I guess I just would really like to move forward and close this, but if others felt the wording is really very bad, please submit a follow-up PR, I'll be happy to review and approve it. I may also do it myself in a free time.

mariha avatar Oct 05 '22 07:10 mariha

Bold move! 🎉

please submit a follow-up PR, I'll be happy to review and approve it

(emphasis mine) Sounds like a good process! Cheers to doocracy and transparency! 🙂

mrkvon avatar Oct 05 '22 14:10 mrkvon