trustroots icon indicating copy to clipboard operation
trustroots copied to clipboard

profile/edit/about component

Open karlkeefer opened this issue 2 years ago • 3 comments

Proposed Changes

  • migrate to a react component for the profile/edit/about screen
  • use a custom hook to make change handlers simple for form fields

Testing Instructions

  • go to your profile edit screen and make various changes

Status

So far it pulls in the existing data, you can edit the text fields and description field, and the save button actually persist the data.

TODOs, some of which need input from @simison

  • port confirm-on-exit
  • port form validation
  • create a date widget (or plug in an existing one)
  • integrate with messageCenter somehow

karlkeefer avatar Nov 04 '21 20:11 karlkeefer

Fabulous! I'll test & review later but meanwhile; you can already use React-i18n t() functions to wrap texts so that we can get them to translating once this PR is merged.

simison avatar Nov 05 '21 11:11 simison

@simison this one isn't ready for testing yet. Still missing a bunch of functionality!

karlkeefer avatar Nov 05 '21 16:11 karlkeefer

Gotcha! Ping me when good. :-)

Oh and on eslint; it also helps to disable eslint per line:

console.log(); // eslint-disable-line

// eslint-disable-next-line
console.log();

simison avatar Nov 06 '21 10:11 simison