trustroots
trustroots copied to clipboard
Video call prompt
Proposed Changes
- Prompting the user to a video call before hosting
Testing Instructions
- click on the Yes, I can host! , you can see this message before sending your first message to someone in the messages layout
Fixes #2571
What about moving it to the right and out of the message window? In the are of "is this convo in the spirit of trustroots" and in mobile just make a green camera symbol to klick.
What would be the purpose of that? It'll be much less visual and I didn't quite understand what you mean with the camera icon... The users need to be aware this is not just a video call button but a room they would both have to enter at the same time, which is why we need text to explain it.... This is unfortunately not a video calling feature that we are adding to the platform, that'll be a little bit more complicated...
Also: why is the whatsapp me in this commit?
The WhatsApp is there because I didn't discard the changes, weird I didn't think VSC would push that, thanks for noticing!
Hey @simison do you think this is something you could merge as is, it's been stagnating for a while and I think it might be better on production the way it is as opposed to not at all?
Are we even allowed to integrate jitsi's server in an app like that? Did anyone check the jitsi fine prints?
Jitsi is nice and all to let people use it's infra for free, but there probably are limits...
I'm pretty sure it's allowed (otherwise we can use any other free jitsi instance out there or run our own). If we are going to merge this then I'll personally communicate this to the jitsi team and maybe they'll put us on their website as an open source community project which uses jitsi, then we'll definitely be in the clear, (otherwise we can remove it)
Also I don't know how integrated jitsi really is in this case we're basically just generation a random URL and telling people to meet...