useDApp icon indicating copy to clipboard operation
useDApp copied to clipboard

Draft work on CustomError

Open ItsShadowl opened this issue 2 years ago • 5 comments

ItsShadowl avatar Jul 29 '22 19:07 ItsShadowl

⚠️ No Changeset found

Latest commit: 386f5cd823d7b72ab5c326d6154c98aed95f3b54

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jul 29 '22 19:07 changeset-bot[bot]

@ItsShadowl We have implementation of CustomErrors, working with Hardhat - please take a look into the tests in action here https://github.com/TrueFiEng/Waffle/blob/12c2d7209a310202e8b03862972a88735e5803a0/waffle-hardhat/test/reverted.test.ts#L37

rzadp avatar Aug 01 '22 14:08 rzadp

@ItsShadowl We have implementation of CustomErrors, working with Hardhat - please take a look into the tests in action here https://github.com/TrueFiEng/Waffle/blob/12c2d7209a310202e8b03862972a88735e5803a0/waffle-hardhat/test/reverted.test.ts#L37

The error args and errorName can't be pulled from UseDapp

ItsShadowl avatar Aug 01 '22 15:08 ItsShadowl

@ItsShadowl Ah sorry I confused UseDapp with Waffle because I switch from one to another during the day 🤦‍♂️

rzadp avatar Aug 01 '22 15:08 rzadp

@ItsShadowl Ah sorry I confused UseDapp with Waffle because I switch from one to another during the day 🤦‍♂️

I did notice that, LOL

ItsShadowl avatar Aug 01 '22 23:08 ItsShadowl