trueblocks-core icon indicating copy to clipboard operation
trueblocks-core copied to clipboard

chifra transactions -- incorrect output for --ether option

Open tjayrush opened this issue 1 year ago • 1 comments

In the current code, when we do chifra transactions 1001001.0 --ether we get an incorrect result. (Same for other command that export transactions including blocks and export).

We always get both the value and the ether field in all exports of a transaction (even if --ether is not provided), but when it is provided we get an incorrect result.

Without the --ether flag, we get Ether in the ether field and Wei in the value field.

With the --ether flag, we get Ether in both fields.

This is incorrect and will be fixed in version 3.0.0.

tjayrush avatar May 02 '24 21:05 tjayrush

This is a slightly breaking change in that people who were relying on the value field to be in Ether when the --ether flag is provided will break, but it's justified since they should have been using the ether field instead.

tjayrush avatar May 02 '24 21:05 tjayrush