webasm-solidity icon indicating copy to clipboard operation
webasm-solidity copied to clipboard

initialize shouldn't return false

Open hswick opened this issue 6 years ago • 1 comments

https://github.com/TrueBitFoundation/webasm-solidity/blob/master/contracts/interactive.sol#L124 https://github.com/TrueBitFoundation/webasm-solidity/blob/master/contracts/interactive.sol#L127

Should just revert when not successful because it makes it seem like the tx went through

Should be deleted because if you don't have the proper data then there is a more underlying fault that probably wont be able to mended.

hswick avatar Jun 07 '18 20:06 hswick

Ok, these are just for debugging, removing them shouldn't do any harm.

mrsmkl avatar Jun 08 '18 09:06 mrsmkl