webasm-solidity icon indicating copy to clipboard operation
webasm-solidity copied to clipboard

Use abi.encodePacked for inputs to keccak256

Open hswick opened this issue 7 years ago • 2 comments

Solidity compiler gives this type of warning quite a bit. fs.sol:52:20: Warning: This function only accepts a single "bytes" argument. Please use "abi.encodePacked(...)" or a similar function to encode the data.

I believe this is a breaking change in 0.5.0, so it would be good to change this sooner than later.

hswick avatar Jun 18 '18 18:06 hswick

Hi @hswick, would it be ok for fundrequest.io to add a tiny bit of funding to this issue, so maybe the community can pick it up?

Qkyrie avatar Jul 05 '18 10:07 Qkyrie

I don’t have a problem with someone else paying for it. As long as we can keep the notifications to a minimum, sometimes these type of services can be really annoying.

hswick avatar Jul 05 '18 13:07 hswick