incentive-layer

incentive-layer copied to clipboard

I don't see where the blockhash field is used. If `n >= block.number`, then `blockhash(n) == 0`

mrsmkl

Something has to be changed here, otherwise the task giver can withdraw or bond the deposit, and the solver cannot register for the task. From comments in the code: LOOK...

mrsmkl

Contract JackpotManager is vulnerable to the locked ether vulnerability

3

I am still meditating on this issue but I have a bit uneasy feeling in the stomach about the JackpotManager. There is a possibility of locked ether vulnerability in the...

thogiti

The most recent pull request of the incentive layer fails on Travis. On closer inspection of the output, the test fails when running: ```> npm run migrate``` This command just...

srya-b

security vulnerability detected in hoek < 5.0.3

2

It looks we may need to update package-lock.json. Github indicates a known issue in https://github.com/hapijs/hoek and recommends package-lock.json update suggested: hoek ~> 5.0.3.

teutsch

Fluctuating Task Size/Jackpot

1

One of the issues with the jackpot is that the size of the Tasks is relative to the size of the jackpot. As in the the maximum cost of a...

hswick

Current jackpot payment adheres to split between solution0Challengers and solution1Challengers. This becomes an issue for 2 reasons 1. Implementation: Verifier needs to get info to redeem payout, this would require...

hswick

Verifier payment

1

Current implementation only rewards solvers after finalization of task. Verifiers are eligible to receive jackpot amount though. Implementation wise this is easiest. Another option is to pay verifiers a portion...

hswick

This we definitely need to restrict. There is a lower bound of reward where the amount of participating in the system is less than the gain. Which isn't a trivial...

hswick

At some point the payment of the jackpot will be less than the amount of gas it takes to receive such a payment. We may or may not want to...

hswick