trusat-frontend icon indicating copy to clipboard operation
trusat-frontend copied to clipboard

Published 20 hours ago • verified publisher icon TruSat

Add logout button to burger menu in mobile

Open martinvarelaaaa opened this issue 4 years ago • 5 comments

Issue #281

  • The logout button is added to the burger menu in the mobile version
  • A logout function is added in auth-helpers to reuse the code

Execution: https://drive.google.com/file/d/1gxiU00UBtjd-h2ktnGNybLqE1KLI9y8x/view

martinvarelaaaa avatar May 28 '20 01:05 martinvarelaaaa

Is "logoutCallback" a misnomer since it is never passed as a callback function?

Ok @thkruz What name do you propose?

martinvarelaaaa avatar May 28 '20 16:05 martinvarelaaaa

@martinvarelaaaa was a genuine question. "closeAndLogout" sounds more intuitive to me if it isn't a callback, but I was mainly just concerned I misunderstood the code (react is a bit confusing to me).

thkruz avatar May 28 '20 16:05 thkruz

Done @thkruz !

martinvarelaaaa avatar May 28 '20 18:05 martinvarelaaaa

@martinvarelaaaa Thanks for this Martín, ill review asap - probably tomorrow.

johngribbin avatar May 28 '20 21:05 johngribbin

Ok perfect @johngribbin! I'll probably turn up the fix tomorrow

martinvarelaaaa avatar May 29 '20 17:05 martinvarelaaaa