trow icon indicating copy to clipboard operation
trow copied to clipboard

Improve Logging

Open amouat opened this issue 5 years ago • 3 comments

Trow should move to proper structured logs and have better, more consistent logging in general. This might be a little hampered by Rocket, which does its own logging (eventually I would like to move to Warp, but that will take some effort).

The first task would be to investigate log & slog support for structured logs and how they can be integrated into Trow. Then we should figure out where logging should happen and what levels should be used when. A much standardised approach to logs is necessary.

Whilts this is a big issue, it can be tackled bit by bit and should be reasonably easy to get started.

amouat avatar Mar 11 '20 15:03 amouat

Looking into this, it seems the tracing crate may be relevant and important: https://tracing-rs.netlify.app/tracing/ Also possibly relevant to #126 in the long run.

amouat avatar Jul 15 '20 10:07 amouat

@iamcaleberic currently looking at this.

amouat avatar Aug 20 '20 12:08 amouat

Another side of this is just figuring out what should be logged and where.

I recently added #197 which added a bunch of log messages - we need to start thinking about how the logs can be used to debug problems and in general build up an idea of what's happening & the ordering of events.

amouat avatar Oct 14 '20 11:10 amouat