trow icon indicating copy to clipboard operation
trow copied to clipboard

Update a bunch of stuff.

Open amouat opened this issue 2 years ago • 4 comments

amouat avatar Jul 05 '23 21:07 amouat

@awoimbee I wanted to merge this before moving, but I no longer have the ability to force merges without review :)

amouat avatar Jul 29 '23 15:07 amouat

I think this PR should only update your email, not a fan of adding unused imports and //TODO: tests are interleaved to avoid some race condition that should be investigated while this race condition does not seem to happen in https://github.com/Extrality/trow

awoimbee avatar Aug 02 '23 08:08 awoimbee

I was mainly trying to update a bunch of dependencies to resolve vulnerabilities. But then the tests didn't pass, so I needed to make some changes.

The alternative is to first merge the extrality fork, would you rather do it that way around?

amouat avatar Aug 02 '23 09:08 amouat

Sorry, missed this one

The alternative is to first merge the extrality fork, would you rather do it that way around?

Absolutely, my fork has a lot of changes, rebasing would not be fun !

awoimbee avatar Sep 11 '23 12:09 awoimbee