TropheusJ

Results 39 comments of TropheusJ

I am planning to fix this next time breaking changes are made, as the API this code is for is just generally bad

going to resurrect this as a new PR, sorry for letting this sit for so long for no real reason

problematic code has been removed

the vanilla changes have been moved to a built-in pack. They will not apply on servers, and fabric clients can disable it if needed. Forge clients cannot disable it as...

I also need this, pretty much need to wrap a whole method in a try-with-resources. Need to wrap a parameter, and then close the wrapper before return.

I may have just fixed this, will need to test release candidate 3 once it's released

I don't think not in house is a good excuse to not use something. If it works, we should use it. I can't really give input on that though since...

out of scope for Porting Lib then

What does this have to do with Porting Lib? `ItemStack.getRecipeRemainder()` is implemented by Fabric API.