L. Kärkkäinen

Results 252 comments of L. Kärkkäinen

The main topic of this issue (and why I labeled it a bug) would not change app.run or CLI interfaces at all, but simply bind to all matching IPs of...

Now the discussion in randomly scattered among the two issues. Bummers. But yes, I concur in general with your points. >What does --public do? EDIT: redacted previous things. I believe...

The above doesn't directly address the initial bootstrapping of the certificates, although the port 80 service certbot's HTTP verification (one can run certbot to obtain certs while it is running)....

Multiple host bindings on one CLI certainly would fit #2657 as well. I see much less use for binding (the same thing) to multiple ports. The suggestion to use port...

Yes, it is clearly its own app (shipped with Sanic, possibly customizable by user). So, are you heading to a direction where the sanic CLI could run multiple apps, listen...

I don't think there should be a *callback* API on `response` but rather something that you could do *inline*, e.g. ```python @app.get("/") async def handler(request: Request): response = await request.respond()...

Still cannot apply within `with` or other control blocks nor be written as inline code without a separate function, variables need to be passed via `request.ctx`, and needs "custom syntax"....

I have no take on that. Only that sending the response inside handler was supposed to be first class API, and after-handler handling only a fallback that calls it (even...

Quick benchmarks with a "Hello World" Sanic webapp: ``` $ wrk -c100 -t8 http://127.0.0.1/ # Nginx no keep-alive Running 10s test @ http://127.0.0.1/ 8 threads and 100 connections Thread Stats...

Sure, a database-heavy benchmark would have less effect by keep-alive. Still, are you sure that you did enable keep-alive? * `proxy_http_version 1.1;` is the obvious bit * `keep_alive` directive in...