manatee icon indicating copy to clipboard operation
manatee copied to clipboard

avoid hard coding the postgres username

Open swills opened this issue 10 years ago • 5 comments

Closes issue #4

Pull request should be right this time. Thanks!

swills avatar Dec 08 '14 03:12 swills

Thanks for doing this. How was this tested?

davepacheco avatar Dec 08 '14 21:12 davepacheco

@yunong can you point me at the lint/style checker?

swills avatar Dec 11 '14 19:12 swills

@davepacheco Tested manually on FreeBSD. If there are tests that need to be run, please let me know where and I will try to run them, though I don't have a complete SDC environment up yet, so if that is required I may not be able to run it.

swills avatar Dec 11 '14 19:12 swills

@swills The test suite and lint/style checkers are run via npm test. Thanks for the patch!

yunong avatar Dec 11 '14 19:12 yunong

Style issues fixed. The tests as far as they can right now, though they hard code the username as well, ironically, so there's more to do. They also hard code some commands, such as zonename, useradd, ctrun.

swills avatar Dec 11 '14 21:12 swills