containerpilot icon indicating copy to clipboard operation
containerpilot copied to clipboard

Maintenance release for 2022

Open teutat3s opened this issue 3 years ago • 2 comments

  • [x] passes make build lint integration

I know this is a big looking PR and I'd like to gather feedback whether upstream is interested in any of the changes. If interested, I could also break this up into into several smaller ones, if that is preferred.

Feature changes include Changelog Incorporated several pull requests, adding one feature and fixing one issue:

  • Run as user per job #570 fixed by PR #584
  • Fix broken integration tests #586

Other notably bigger changes:

  • moved project to go modules
  • removed unnecessary glide dependency

Lots of smaller changes, mainly maintenance related:

  • bump minimum go version to 1.17
  • bump go dependencies and fixes for prometheus upstream API changes
  • bump consul version to 1.11.4
  • linting: use staticcheck instead of deprecated golint
  • apply staticcheck lint changes
  • make scripts work on NixOS
  • some gofmt

Summaries: Changes since last upstream release 3.8.0 https://github.com/joyent/containerpilot/compare/3.8.0...greenbaum:3.8.4 Changes since last forked release 3.8.3 https://github.com/greenbaum/containerpilot/compare/3.8.3...greenbaum:3.8.4

teutat3s avatar Apr 14 '22 14:04 teutat3s

A successful CI run can be inspected here by the interested reader https://drone.greenbaum.cloud/greenbaum.cloud/containerpilot/40

teutat3s avatar Apr 14 '22 14:04 teutat3s

I'm sorry for not having looked at this. There's a lot here. I've added myself and two others as reviewers. I see there are test results above, which may help us in making the decision to merge.

I'm thinking it should be a series of smaller squashable-to-one-commit PRs, however, as that's how we normally roll (squish one PR into one commit).

danmcd avatar Nov 04 '22 17:11 danmcd