Tristan de Cacqueray

Results 180 comments of Tristan de Cacqueray
trafficstars

If that looks good to you, I'll update the other advisories.

Thank you for the review @frasertweedale! I'll address the rest of the comments tomorrow.

@frasertweedale I'm tempted to close this PR, though I think it can be useful to quickly lookup the name. What do you think, should I rebase it instead?

> For `zip`, I was expecting a solution like this Hello @david-christiansen , for what it's worth, I wrote: ```lean def zip {α β : Type} (xs : List α)...

@Bodigrim sure, well there was no test for Data.Text.Foreign, so I added new ioProperties. Please let me know if that's what you want.

@Lysxia Hello, could you please have a look?

@fhammerschmidt Thanks, using `.res.mjs` still failed with: ``` Module not found: Can't resolve '@rescript/core/src/Core__List.res.mjs' ``` Using `.mjs` directly worked, but now the build is failing with: ``` Module not found:...

Also switching to `"jsx": {"version": 4, "mode": "classic"}` results in: ``` ./node_modules/@softwarefactory-project/re-ansi/src/Ansi.mjs Can't import the named export 'createElement' from non EcmaScript module (only default export is available) ``` Note that...

Ok sorry about the noise, but if I understand correctly, create-react-app does not support mjs files out of the box according to https://github.com/facebook/create-react-app/issues/10356 . It would be better if we...

Well I'm not familiar with react/vite/next, and my issue is that using `mjs` is a breaking change for CRA users. It looks like `.mjs` is the way to go nowadays,...