OnlineBookSales icon indicating copy to clipboard operation
OnlineBookSales copied to clipboard
Published 1 year ago • verified publisher icon Trisha-tech

[Bug]: the websites footer color style is not contrast with the header color

Open Anu142004 opened this issue 1 year ago • 19 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Issue Description

It is good to keep the header and footer color as same it will contrast each other in which it could help to create a better looking website .

Suggested Change

change the footer with same color as the header

Rationale

to make the website more appearance and good looking

Urgency

High

Record

  • [X] I have read the Contributing Guidelines
  • [X] I'm a GSSOC'24 contributor
  • [X] I have starred the repository

Anu142004 avatar Oct 15 '24 14:10 Anu142004

Hi there! Thanks for opening this issue. We appreciate your contribution to this open-source project. We aim to respond or assign your issue as soon as possible.

github-actions[bot] avatar Oct 15 '24 14:10 github-actions[bot]

Is there an existing issue for this?

* [x]  I have searched the existing issues

Issue Description

It is good to keep the header and footer color as same it will contrast each other in which it could help to create a better looking website .

Suggested Change

change the footer with same color as the header

Rationale

to make the website more appearance and good looking

Urgency

High

Record

* [x]  I have read the Contributing Guidelines

* [x]  I'm a GSSOC'24 contributor

* [x]  I have starred the repository

You may provide some screenshots for better clarity.

Suman373 avatar Oct 16 '24 06:10 Suman373

ok

Anu142004 avatar Oct 17 '24 03:10 Anu142004

shall i work on this

Anu142004 avatar Oct 18 '24 11:10 Anu142004

shall i work on this

Yes u can. Am assigning this to you. Good luck!

Suman373 avatar Oct 18 '24 12:10 Suman373

thank you

Anu142004 avatar Oct 18 '24 13:10 Anu142004

pl do send the html file

Anu142004 avatar Oct 19 '24 15:10 Anu142004

pl do send the html file

There is only one index.html file which is the starting file of the project. All the code is written in reactjs. Do you know ReactJS? @Anu142004

Trisha-tech avatar Oct 20 '24 11:10 Trisha-tech

no

Anu142004 avatar Oct 20 '24 12:10 Anu142004

no

Do you need any help ? @Anu142004

officeneerajsaini avatar Oct 22 '24 15:10 officeneerajsaini

@Suman373, I found an issue with this repo's live web code. The repo's code differs slightly from each other.

Screenshot 2024-10-22 at 8 52 06 PM Screenshot 2024-10-22 at 8 51 34 PM

Header and Footer class properties are a mismatch

officeneerajsaini avatar Oct 22 '24 15:10 officeneerajsaini

Thank you

Anu142004 avatar Oct 22 '24 16:10 Anu142004

@Suman373, I found an issue with this repo's live web code. The repo's code differs slightly from each other. Screenshot 2024-10-22 at 8 52 06 PM Screenshot 2024-10-22 at 8 51 34 PM

Header and Footer class properties are a mismatch

Hey ! Thanks for notifying us, I'll talk to the PA regarding this.

Suman373 avatar Oct 22 '24 17:10 Suman373

@Trisha-tech please review this issue.

officeneerajsaini avatar Oct 23 '24 09:10 officeneerajsaini

@officeneerajsaini Do you want to work on this ?

Suman373 avatar Oct 23 '24 09:10 Suman373

Yes, I want to work on it. @Suman373 Please assign to me .

officeneerajsaini avatar Oct 23 '24 10:10 officeneerajsaini

Yes, I want to work on it. @Suman373 Please assign to me .

All the best!

Suman373 avatar Oct 23 '24 10:10 Suman373

@Suman373 have you asked the maintainer why both websites are different? @Trisha-tech Please Take a Look at this issue.

officeneerajsaini avatar Oct 25 '24 03:10 officeneerajsaini

@Suman373 have you asked the maintainer why both websites are different? @Trisha-tech Please Take a Look at this issue.

Yes, the deployed version points to a different commit and not the latest one. PA will update it soon.

Suman373 avatar Oct 27 '24 07:10 Suman373