OnlineBookSales icon indicating copy to clipboard operation
OnlineBookSales copied to clipboard

FIxed two bugs and added testimonial section

Open AasthaSingh28 opened this issue 1 year ago • 7 comments

Description

A clear and concise description of what the PR does.

  • This PR does the following:
    • Adds ... Added Testimonial.jsx and testimonial.css
    • Fixes ... Fixed bugs in Home.jsx and the duplicate index.js
    • Updates ... Changed the name of Index.js inside Component to index2.js

Related Issues

Link any related issues using the format Fixes #issue_number. This helps to automatically close related issues when the PR is merged.

  • Placeholder: "Fixes #417 "

Changes

List the detailed changes made in this PR.

  • Added a new feature to ... Home.jsx
  • Refactored the ...
  • Fixed a bug in ...Fixed bugs in Home.jsx and the duplicate index.js

Testing Instructions

Detailed instructions on how to test the changes. Include any setup needed and specific test cases.

  1. Pull this branch.
  2. Run npm install to install dependencies.
  3. Run npm test to execute the test suite.
  4. Verify that ...

Screenshots (if applicable)

Add any screenshots that help explain or visualize the changes.

Additional Context

Any additional context or information that reviewers should be aware of.

  • This PR is based on the following...

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

  • [ ] I have performed a self-review of my code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] My changes generate no new warnings
  • [ ] I am working on this issue under GSSOC

AasthaSingh28 avatar Oct 14 '24 13:10 AasthaSingh28

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

github-actions[bot] avatar Oct 14 '24 13:10 github-actions[bot]

Hey @Trisha-tech please give me the write access so that I can resolve the conflicts by myself :)

AasthaSingh28 avatar Oct 14 '24 13:10 AasthaSingh28

Description

A clear and concise description of what the PR does.

  • This PR does the following:

    • Adds ... Added Testimonial.jsx and testimonial.css
    • Fixes ... Fixed bugs in Home.jsx and the duplicate index.js
    • Updates ... Changed the name of Index.js inside Component to index2.js

Related Issues

Link any related issues using the format Fixes #issue_number. This helps to automatically close related issues when the PR is merged.

Changes

List the detailed changes made in this PR.

  • Added a new feature to ... Home.jsx
  • Refactored the ...
  • Fixed a bug in ...Fixed bugs in Home.jsx and the duplicate index.js

Testing Instructions

Detailed instructions on how to test the changes. Include any setup needed and specific test cases.

  1. Pull this branch.
  2. Run npm install to install dependencies.
  3. Run npm test to execute the test suite.
  4. Verify that ...

Screenshots (if applicable)

Add any screenshots that help explain or visualize the changes.

Additional Context

Any additional context or information that reviewers should be aware of.

  • This PR is based on the following...

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

  • [ ] I have performed a self-review of my code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] My changes generate no new warnings
  • [ ] I am working on this issue under GSSOC

Kindly add some screenshot or screen recording of the features you have made. @AasthaSingh28 and for resolving the conflicts just pull the upstream code and accept the incoming changes.

Trisha-tech avatar Oct 14 '24 14:10 Trisha-tech

@AasthaSingh28 Follow the instructions given by Project admin and then we can merge your PR

Suman373 avatar Oct 16 '24 14:10 Suman373

@Suman373 Can you please give me the write acces so that I can resolve the conflicts in this branch and make PR ready to merge asap?

AasthaSingh28 avatar Oct 16 '24 14:10 AasthaSingh28

@Suman373 Can you please give me the write acces so that I can resolve the conflicts in this branch and make PR ready to merge asap?

You can fix the conflicts by accepting incoming changes from upstream. I am not allowed/eligible to provide write access to contributors.

Suman373 avatar Oct 18 '24 17:10 Suman373

@AasthaSingh28 accept the incoming changes and resolve the conflicts from your side to get pull request merged

mridulsaggi avatar Nov 07 '24 05:11 mridulsaggi