OnlineBookSales icon indicating copy to clipboard operation
OnlineBookSales copied to clipboard

Added more features in the home page

Open Dipanita45 opened this issue 1 year ago • 18 comments

Description

Modified the css properties like transition, text decoration, color , ..etc

  • This PR does the following:

    • Adds ...yes
    • Updates ... yes
  • Placeholder: "Fixes #470

Changes

List the detailed changes made in this PR.

  • Added a new feature to ... to the website view

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

  • [yes] I have performed a self-review of my code
  • [yes ] I have commented my code, particularly in hard-to-understand areas
  • [ yes] My changes generate no new warnings
  • [yes] I am working on this issue under GSSOC

Please review and label me Thank you for the chance @Trisha-tech

Dipanita45 avatar Oct 14 '24 12:10 Dipanita45

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

github-actions[bot] avatar Oct 14 '24 12:10 github-actions[bot]

Kindoy### Description

Modified the css properties like transition, text decoration, color , ..etc

Changes

List the detailed changes made in this PR.

  • Added a new feature to ... to the website view

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

  • [yes] I have performed a self-review of my code
  • [yes ] I have commented my code, particularly in hard-to-understand areas
  • [ yes] My changes generate no new warnings
  • [yes] I am working on this issue under GSSOC

Please review and label me Thank you for the chance @Trisha-tech

Kindly add some screenshot or screen recording of the features you have made. @Dipanita45

Trisha-tech avatar Oct 14 '24 14:10 Trisha-tech

Okay

On Mon, 14 Oct 2024, 7:40 pm Trisha Sahu, @.***> wrote:

Kindoy### Description

Modified the css properties like transition, text decoration, color , ..etc

This PR does the following:

  • Adds ...yes
    • Updates ... yes

Placeholder: "Fixes [Feature Request]: Add more features of the home page #470 https://github.com/Trisha-tech/OnlineBookSales/issues/470

Changes

List the detailed changes made in this PR.

  • Added a new feature to ... to the website view

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

  • [yes] I have performed a self-review of my code
  • [yes ] I have commented my code, particularly in hard-to-understand areas
  • [ yes] My changes generate no new warnings
  • [yes] I am working on this issue under GSSOC

Please review and label me Thank you for the chance @Trisha-tech https://github.com/Trisha-tech

Kindly add some screenshot or screen recording of the features you have made. @Dipanita45 https://github.com/Dipanita45

— Reply to this email directly, view it on GitHub https://github.com/Trisha-tech/OnlineBookSales/pull/474#issuecomment-2411383357, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7SRZ6HF6UBR44GLA4AZAVLZ3PGEHAVCNFSM6AAAAABP457HAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJRGM4DGMZVG4 . You are receiving this because you were mentioned.Message ID: @.***>

Dipanita45 avatar Oct 14 '24 14:10 Dipanita45

Due to some reasons screenshot is not uploading Sorry @Trisha-tech Please label me

Dipanita45 avatar Oct 14 '24 16:10 Dipanita45

Please merge my pull request

Dipanita45 avatar Oct 22 '24 17:10 Dipanita45

Please merge my pull request

You need to provide some demo/snapshot because you have updated the UI. I am labelling and reopening the PR but make sure to upload it here or else we can't merge it. Thank you

Suman373 avatar Oct 22 '24 17:10 Suman373

@Dipanita45 Kindly pull latest changes from the master branch and accept the incoming changes so that the conflicts are resolved.

image

Suman373 avatar Oct 22 '24 17:10 Suman373

Screenshot 2024-10-23 003007

Please merge the pull request and label me level 2 @Trisha-tech

Dipanita45 avatar Oct 22 '24 19:10 Dipanita45

Screenshot 2024-10-23 003007

Please merge the pull request and label me level 2 @Trisha-tech

Kindly specify the changes you have made. @Dipanita45

Trisha-tech avatar Oct 29 '24 10:10 Trisha-tech

I have done modify in some of the css properties of the website for its looks for more attractive

On Tue, 29 Oct 2024, 3:38 pm Trisha Sahu, @.***> wrote:

[image: Screenshot 2024-10-23 003007] https://private-user-images.githubusercontent.com/132455672/378984737-a665a153-61e9-4e4a-bb82-a2df552fe67f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzAxOTY3NDksIm5iZiI6MTczMDE5NjQ0OSwicGF0aCI6Ii8xMzI0NTU2NzIvMzc4OTg0NzM3LWE2NjVhMTUzLTYxZTktNGU0YS1iYjgyLWEyZGY1NTJmZTY3Zi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQxMDI5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MTAyOVQxMDA3MjlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1kOWNmZDlkNDEwMWU3NjFmNWI3ZjUxZmRjZjMyZWZkMjY2YTZjOTQ2ZDM3YzZmMGY1OTMzOWFiNjlhYjYwNzE5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.byBpId0vB_KfiEWVwQeflp9lBbVoMnV0Ij3ftDtLNFE

Please merge the pull request and label me level 2 @Trisha-tech https://github.com/Trisha-tech

Kindly specify the changes you have made. @Dipanita45 https://github.com/Dipanita45

— Reply to this email directly, view it on GitHub https://github.com/Trisha-tech/OnlineBookSales/pull/474#issuecomment-2443779532, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7SRZ6EV44AIBPQHCMN3LTTZ55NDTAVCNFSM6AAAAABP457HAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBTG43TSNJTGI . You are receiving this because you were mentioned.Message ID: @.***>

Dipanita45 avatar Oct 29 '24 10:10 Dipanita45

Please merge my pull request

On Tue, 29 Oct 2024, 3:57 pm Dipanita Mondal, @.***> wrote:

I have done modify in some of the css properties of the website for its looks for more attractive

On Tue, 29 Oct 2024, 3:38 pm Trisha Sahu, @.***> wrote:

[image: Screenshot 2024-10-23 003007] https://private-user-images.githubusercontent.com/132455672/378984737-a665a153-61e9-4e4a-bb82-a2df552fe67f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzAxOTY3NDksIm5iZiI6MTczMDE5NjQ0OSwicGF0aCI6Ii8xMzI0NTU2NzIvMzc4OTg0NzM3LWE2NjVhMTUzLTYxZTktNGU0YS1iYjgyLWEyZGY1NTJmZTY3Zi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQxMDI5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MTAyOVQxMDA3MjlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1kOWNmZDlkNDEwMWU3NjFmNWI3ZjUxZmRjZjMyZWZkMjY2YTZjOTQ2ZDM3YzZmMGY1OTMzOWFiNjlhYjYwNzE5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.byBpId0vB_KfiEWVwQeflp9lBbVoMnV0Ij3ftDtLNFE

Please merge the pull request and label me level 2 @Trisha-tech https://github.com/Trisha-tech

Kindly specify the changes you have made. @Dipanita45 https://github.com/Dipanita45

— Reply to this email directly, view it on GitHub https://github.com/Trisha-tech/OnlineBookSales/pull/474#issuecomment-2443779532, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7SRZ6EV44AIBPQHCMN3LTTZ55NDTAVCNFSM6AAAAABP457HAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBTG43TSNJTGI . You are receiving this because you were mentioned.Message ID: @.***>

Dipanita45 avatar Oct 29 '24 19:10 Dipanita45

@Dipanita45 add the ss of the changes that have you made with reference to the original ss. Do resolve the merge conflicts

mridulsaggi avatar Nov 07 '24 05:11 mridulsaggi

Okay

Dipanita45 avatar Nov 07 '24 05:11 Dipanita45

Last conficts is not resolving @Trisha-tech

Dipanita45 avatar Nov 07 '24 07:11 Dipanita45

please please merge my pull request and label me @Trisha-tech

Dipanita45 avatar Nov 09 '24 05:11 Dipanita45

please please merge my pull request and label me @Trisha-tech

Pull the latest changes from the master branch and add it. Accept the incoming changes.

Suman373 avatar Nov 09 '24 11:11 Suman373

I have to sync fork

On Sat, 9 Nov 2024, 5:18 pm Suman Roy, @.***> wrote:

please please merge my pull request and label me @Trisha-tech https://github.com/Trisha-tech

Push the latest changes from the master branch and add it. Accept the incoming changes.

— Reply to this email directly, view it on GitHub https://github.com/Trisha-tech/OnlineBookSales/pull/474#issuecomment-2466185412, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7SRZ6HBJZPHD7Z6ABJEVBLZ7XZCBAVCNFSM6AAAAABP457HAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRWGE4DKNBRGI . You are receiving this because you were mentioned.Message ID: @.***>

Dipanita45 avatar Nov 09 '24 11:11 Dipanita45

I have to sync fork On Sat, 9 Nov 2024, 5:18 pm Suman Roy, @.> wrote: please please merge my pull request and label me @Trisha-tech https://github.com/Trisha-tech Push the latest changes from the master branch and add it. Accept the incoming changes. — Reply to this email directly, view it on GitHub <#474 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7SRZ6HBJZPHD7Z6ABJEVBLZ7XZCBAVCNFSM6AAAAABP457HAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRWGE4DKNBRGI . You are receiving this because you were mentioned.Message ID: @.>

If the conflicts are getting too complex, I would advise you to make the changes in a new fork. Delete the current fork of yours and fix this issue again.

Suman373 avatar Nov 09 '24 11:11 Suman373