WowPacketParser icon indicating copy to clipboard operation
WowPacketParser copied to clipboard

Published 20 hours ago • verified publisher icon TrinityCore

Create ObjectNames sql output is broken

Open Vincent-Michael opened this issue 9 years ago • 2 comments

Support current: https://github.com/TrinityCore/WowPacketParser/blob/888f64830cbf782dd4dd4ac61e2ed01762d46ca3/WowPacketParser/Store/Objects/ObjectName.cs#L9-L10

https://github.com/TrinityCore/WowPacketParser/blob/888f64830cbf782dd4dd4ac61e2ed01762d46ca3/WowPacketParser/Enums/ObjectType.cs#L3-L17

Should but: https://github.com/TrinityCore/WowPacketParser/blob/888f64830cbf782dd4dd4ac61e2ed01762d46ca3/WowPacketParser/Enums/StoreNameType.cs#L5-L29

https://github.com/TrinityCore/WowPacketParser/blob/888f64830cbf782dd4dd4ac61e2ed01762d46ca3/WowPacketParser/SQL/SQLDatabase.cs#L53-L61

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/29479773-create-objectnames-sql-output-is-broken?utm_campaign=plugin&utm_content=tracker%2F457228&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F457228&utm_medium=issues&utm_source=github).

Vincent-Michael avatar Dec 30 '15 10:12 Vincent-Michael

It seems it was already messed up before my changes. See https://github.com/TrinityCore/WowPacketParser/blob/11e41175877cfd7c0389be5659bd1ee4a129daed/WowPacketParser/Parsing/Parsers/GameObjectHandler.cs#L58-L63

Carbenium avatar Dec 30 '15 13:12 Carbenium

hm okay, we should rewrite with #219

Vincent-Michael avatar Dec 30 '15 21:12 Vincent-Michael